Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: InseeFrLab/onyxia-ui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.1.0
Choose a base ref
...
head repository: InseeFrLab/onyxia-ui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.1.1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 16, 2024

  1. Fix passing key with spread operator

    @garronej
    garronej committed Nov 16, 2024

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    01945ea View commit details

  2. Bump version

    @garronej
    garronej committed Nov 16, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    0265ac4 View commit details
Showing with 2 additions and 3 deletions.
  1. +1 −1 package.json
  2. +1 −2 src/ButtonBar.tsx
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "onyxia-ui",
"version": "6.1.0",
"version": "6.1.1",
"description": "The Onyxia UI toolkit",
"repository": {
"type": "git",
3 changes: 1 addition & 2 deletions src/ButtonBar.tsx
View file
Original file line number Diff line number Diff line change
@@ -52,16 +52,15 @@ function NonMemoizedButtonBar<ButtonId extends string>(
<ButtonBarButton
startIcon={button.icon}
disabled={button.isDisabled ?? false}
key={"link" in button ? button.link.href : button.buttonId}
{...("link" in button
? {
key: button.link.href,
href: button.link.href,
onClick: button.link.onClick,
doOpenNewTabIfHref:
button.link.target === "_blank",
}
: {
key: button.buttonId,
onClick: onClickFactory(button.buttonId),
})}
>