Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edge authentication support #101

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 23, 2024

Proposed Changes

Adds auth_scheme keyword argument to InfluxDBClient initialization to allow setting other token authentication scheme other then the default "Token" (used for Cloud). For Edge (OSS), users need to set it to "Bearer".

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Sorry, something went wrong.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.44%. Comparing base (9fd9ebc) to head (474dc24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   54.34%   54.44%   +0.09%     
==========================================
  Files          33       33              
  Lines        2046     2046              
==========================================
+ Hits         1112     1114       +2     
+ Misses        934      932       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 23, 2024 09:57
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@alespour alespour merged commit 65d64e2 into main Aug 5, 2024
13 checks passed
@alespour alespour deleted the fix/edge-authentication-support branch August 5, 2024 14:15
@bednar bednar added this to the 0.8.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants