Fix: render extensions also for EntityDescriptor and IdPSSODescriptor #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While extensions configured for an SP are processed (inside SPSSODescriptor), extensions defined at the EntityDescriptor level were ignored. Render the extensions also on the EntityDescriptor level.
|
Hi @c00kiemon5ter , I've now added the handling of extensions also for AA, AQ and PDP descriptors - the PR should be complete. Please let me know what you think. Cheers, |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @c00kiemon5ter ,
I have noticed that while extra (metadata) extensions given as part of SP config are rendered in the metadata, they're ignored when given at the EntityDescriptor level (where e.g. RegistrationInfo should be rendered).
I have followed the style of how an SPSSODescriptor renderes the extensions and added it for EntityDescriptor - works as expected.
For completeness, I've also checked what other code paths might suffer from the same issue and added the rendering of extensions also for IdPSSODescriptor.
I see there are also similar functions for AA, AQ and PDP descriptors - I could add the same schematic code for completeness, but wanted to check with you first.
Your thoughts on this?
Should I cover the remaining descriptor types and would you then be happy to merge this PR?
Thanks a lot in advance for getting back to me.
Cheers,
Vlad
Checklist