Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): updated the sdk as per the api spec released on 2024-09-17 #100

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

uibm
Copy link
Member

@uibm uibm commented Sep 17, 2024

Ran 3350 of 3350 Specs in 91.700 seconds
SUCCESS! -- 3350 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestVpcV1 (92.50s)
PASS
ok      github.com/IBM/vpc-go-sdk/vpcv1 93.591s

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
@uibm uibm requested a review from sreekarbvibm September 17, 2024 08:14
sreekarbvibm
sreekarbvibm previously approved these changes Sep 17, 2024
Copy link

@sreekarbvibm sreekarbvibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreekarbvibm sreekarbvibm self-requested a review September 17, 2024 08:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
@uibm uibm merged commit d797ca7 into master Sep 17, 2024
3 checks passed
@uibm uibm deleted the release-2024-09-17 branch September 17, 2024 09:02
@uibm uibm added the released label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants