feat: add BuildSpnFunc to GSSAPIConfig for allow custom spn #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fooofei <aihujianfei@qq.com>
|
@fooofei thanks for the PRs, we have seen them and don’t worry we will get around to reviewing both, it isn’t necessary to keep notifying us. If you need to use the capability right away you can point your app code at your branch |
|
@dnwe Have passed 30 days after first pr #2773. I have left about 10 days, so I have another pr #2807 to reach that goal |
|
Released in v1.43.0 |
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/IBM/sarama](https://togithub.com/IBM/sarama) | `v1.42.2` -> `v1.43.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>IBM/sarama (github.com/IBM/sarama)</summary> ### [`v1.43.0`](https://togithub.com/IBM/sarama/releases/tag/v1.43.0): Version 1.43.0 (2024-02-22) [Compare Source](https://togithub.com/IBM/sarama/compare/v1.42.2...v1.43.0) <!-- Release notes generated using configuration in .github/release.yaml at main --> > \[!NOTE]\ > The go.mod directive has been bumped to 1.19 as the minimum version of Go required for the module. This was necessary to continue to receive updates from some of the third party dependencies that Sarama makes use of for compression. #### What's Changed ##### 🎉 New Features / Improvements - feat: update go directive to 1.19 by [@​dnwe](https://togithub.com/dnwe) in [IBM/sarama#2795 - feat: add BuildSpnFunc to GSSAPIConfig for allow custom spn by [@​fooofei](https://togithub.com/fooofei) in [IBM/sarama#2807 ##### 🐛 Fixes - Use %v formatting words and remove unnecessary newline by [@​puellanivis](https://togithub.com/puellanivis) in [IBM/sarama#2802 ##### 📦 Dependency updates - chore(deps): bump github.com/klauspost/compress from 1.16.7 to 1.17.6 by [@​dependabot](https://togithub.com/dependabot) in [IBM/sarama#2784 - chore(deps): bump github.com/eapache/go-resiliency from 1.5.0 to 1.6.0 by [@​dependabot](https://togithub.com/dependabot) in [IBM/sarama#2810 - chore(deps): bump github.com/klauspost/compress from 1.17.6 to 1.17.7 by [@​dependabot](https://togithub.com/dependabot) in [IBM/sarama#2811 ##### 🔧 Maintenance - chore(doc): add v1.42.2 to CHANGELOG.md by [@​dnwe](https://togithub.com/dnwe) in [IBM/sarama#2796 #### New Contributors - [@​puellanivis](https://togithub.com/puellanivis) made their first contribution in [IBM/sarama#2802 - [@​fooofei](https://togithub.com/fooofei) made their first contribution in [IBM/sarama#2807 **Full Changelog**: IBM/sarama@v1.42.2...v1.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
](https://renovatebot.com){kind=link}
…etry#31427) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/IBM/sarama](https://togithub.com/IBM/sarama) | `v1.42.2` -> `v1.43.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>IBM/sarama (github.com/IBM/sarama)</summary> ### [`v1.43.0`](https://togithub.com/IBM/sarama/releases/tag/v1.43.0): Version 1.43.0 (2024-02-22) [Compare Source](https://togithub.com/IBM/sarama/compare/v1.42.2...v1.43.0) <!-- Release notes generated using configuration in .github/release.yaml at main --> > \[!NOTE]\ > The go.mod directive has been bumped to 1.19 as the minimum version of Go required for the module. This was necessary to continue to receive updates from some of the third party dependencies that Sarama makes use of for compression. #### What's Changed ##### 🎉 New Features / Improvements - feat: update go directive to 1.19 by [@&open-telemetry#8203;dnwe](https://togithub.com/dnwe) in [IBM/sarama#2795 - feat: add BuildSpnFunc to GSSAPIConfig for allow custom spn by [@&open-telemetry#8203;fooofei](https://togithub.com/fooofei) in [IBM/sarama#2807 ##### 🐛 Fixes - Use %v formatting words and remove unnecessary newline by [@&open-telemetry#8203;puellanivis](https://togithub.com/puellanivis) in [IBM/sarama#2802 ##### 📦 Dependency updates - chore(deps): bump github.com/klauspost/compress from 1.16.7 to 1.17.6 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [IBM/sarama#2784 - chore(deps): bump github.com/eapache/go-resiliency from 1.5.0 to 1.6.0 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [IBM/sarama#2810 - chore(deps): bump github.com/klauspost/compress from 1.17.6 to 1.17.7 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [IBM/sarama#2811 ##### 🔧 Maintenance - chore(doc): add v1.42.2 to CHANGELOG.md by [@&open-telemetry#8203;dnwe](https://togithub.com/dnwe) in [IBM/sarama#2796 #### New Contributors - [@&open-telemetry#8203;puellanivis](https://togithub.com/puellanivis) made their first contribution in [IBM/sarama#2802 - [@&open-telemetry#8203;fooofei](https://togithub.com/fooofei) made their first contribution in [IBM/sarama#2807 **Full Changelog**: IBM/sarama@v1.42.2...v1.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what this pr is
The new pr is a custom config enhancement that allows the creation of custom spn build.
After allow custom spn build, this also will satisfy #2437
how to implement
add a function type
type BuildSpnFunc func(serviceName, host string) stringadd a field
BuildSpn BuildSpnFunctotype GSSAPIConfig structthen user can set a custom
BuildSpntests result