Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): Update query param for getting reports snapshot list #284

Merged
merged 1 commit into from Oct 17, 2023

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Oct 17, 2023

PR summary

Add new query parameters to support pagination of API: /v1/billing-reports-snapshots

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…list

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
@pyrooka pyrooka self-requested a review October 17, 2023 14:58
@pyrooka pyrooka self-assigned this Oct 17, 2023
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyrooka pyrooka merged commit 51bea2b into IBM:main Oct 17, 2023
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 17, 2023
# [0.52.0](v0.51.0...v0.52.0) (2023-10-17)

### Features

* **Usage Reports:** Update query param for getting reports snapshot list ([#284](#284)) ([51bea2b](51bea2b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.52.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants