Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Metrics Router): add new region eu-es #280

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

adya1303
Copy link
Contributor

@adya1303 adya1303 commented Sep 25, 2023

PR summary

Added new region Madrid(eu-es) to metrics-router

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Added new region. No change in old code

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@adya1303 adya1303 marked this pull request as draft September 25, 2023 05:43
ADYA NAND JHA added 2 commits September 25, 2023 11:17
Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
@adya1303 adya1303 changed the title fix(metrics router) Added new region eu-es fix(metrics router): Added new region eu-es Sep 25, 2023
@padamstx
Copy link
Member

Is this a duplicate of #281?

@adya1303
Copy link
Contributor Author

Is this a duplicate of #281?

No Phil. This one is for metrics-router. I changed the description for 281. That is for Atracker.

@adya1303
Copy link
Contributor Author

Ran integration tests -
image

@adya1303 adya1303 marked this pull request as ready for review September 26, 2023 03:47
@padamstx padamstx changed the title fix(metrics router): Added new region eu-es fix(Metrics Router): add new region eu-es Sep 27, 2023
Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
@padamstx padamstx self-assigned this Sep 27, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit b8834b8 into IBM:main Sep 27, 2023
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Sep 27, 2023
## [0.50.3](v0.50.2...v0.50.3) (2023-09-27)

### Bug Fixes

* **Metrics Router:** add new region eu-es ([#280](#280)) ([b8834b8](b8834b8))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.50.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adya1303 adya1303 deleted the add-eu-es-region branch September 27, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants