Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating .secrets.baseline to suppress false positives for dnssvc #152

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

gahlaut-rahul
Copy link
Collaborator

@gahlaut-rahul gahlaut-rahul commented Oct 10, 2023

PR summary

This PR is to suppress false positive found during detect secrets audit.

Fixes:
This PR is to suppress false positive found during detect secrets audit (false positives for dnssvc).

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR is to suppress false positive found during detect secrets audit.

Sorry, something went wrong.

@@ -340,6 +340,7 @@
},
{
"hashed_secret": "1d89e078341c408a1e98bf14734cefeb59631c2a",
"is_secret": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"is_secret": true,
"is_secret": false,

Signed-off-by: RAHUL <rahul.gahlaut@ibm.com>
Signed-off-by: RAHUL <rahul.gahlaut@ibm.com>
@gahlaut-rahul gahlaut-rahul merged commit 9f31881 into master Oct 12, 2023
@MalarvizhiK
Copy link
Member

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants