Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updating .secrets.baseline to suppress false positives #150

Merged
merged 1 commit into from
Sep 12, 2023
Merged

feat: updating .secrets.baseline to suppress false positives #150

merged 1 commit into from
Sep 12, 2023
+219 −100

Conversation

jkalandaibm
Copy link
Collaborator

@jkalandaibm jkalandaibm commented Sep 8, 2023 •
edited
Loading

dependency: none

PR summary

The PR's objective is to surppress the newly detected false positive secrets.

Fixes:
List of false positives:

FOUND SECRETS:
File: CHANGELOG.md Line: 150 Type: Secret Keyword
File: authenticatedoriginpullapiv1/authenticated_origin_pull_api_v1.go Line: 421 Type: Secret Keyword
File: authenticatedoriginpullapiv1/authenticated_origin_pull_api_v1.go Line: 762 Type: Secret Keyword
File: authenticatedoriginpullapiv1/authenticated_origin_pull_api_v1_integration_test.go Line: 168 Type: Private Key
File: authenticatedoriginpullapiv1/authenticated_origin_pull_api_v1_test.go Line: 66 Type: Secret Keyword
File: authenticatedoriginpullapiv1/authenticated_origin_pull_api_v1_test.go Line: 3056 Type: Private Key
File: botanalyticsv1/bot_analytics_v1_test.go Line: 66 Type: Secret Keyword
File: botmanagementv1/bot_management_v1_test.go Line: 66 Type: Secret Keyword
File: directlink.env.properties Line: 2 Type: Secret Keyword
File: dnssvcsv1/dns_svcs_v1_test.go Line: 14497 Type: Hex High Entropy String
File: mtlsv1/mtls_v1_test.go Line: 62 Type: Secret Keyword
File: mtlsv1/mtls_v1_test.go Line: 2249 Type: Hex High Entropy String
File: mtlsv1/mtls_v1_test.go Line: 2249 Type: Hex High Entropy String

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@jkalandaibm
feat: updating .secrets.baseline to suppress false positives
759da8b 
dependency: none
Signed-off-by: jkalandaibm <jkalanda@us.ibm.com>
@jkalandaibm jkalandaibm force-pushed the updating-secrets-baseline branch from 0884a42 to 759da8b Compare September 8, 2023 20:40
purandarrao
purandarrao approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@purandarrao purandarrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkalandaibm jkalandaibm merged commit 9d1ba7d into master Sep 12, 2023
@kennburger kennburger deleted the updating-secrets-baseline branch September 12, 2023 17:27
MalarvizhiK pushed a commit that referenced this pull request Oct 12, 2023
@semantic-release-bot
chore(release): 0.43.0 release notes [skip ci]
4ea7153 
# [0.43.0](v0.42.2...v0.43.0) (2023-10-12)

### Features

* updating .secrets.baseline to suppress [secure] positives ([#150](#150)) ([9d1ba7d](9d1ba7d))
@MalarvizhiK
Copy link
Member

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jkalandaibm pushed a commit that referenced this pull request Nov 1, 2023
@semantic-release-bot @jkalandaibm
chore(release): 0.43.0 release notes [skip ci]
d7a9458 
# [0.43.0](v0.42.2...v0.43.0) (2023-10-12)

### Features

* updating .secrets.baseline to suppress [secure] positives ([#150](#150)) ([9d1ba7d](9d1ba7d))

Signed-off-by: jkalandaibm <jkalanda@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purandarrao purandarrao

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkalandaibm @MalarvizhiK @purandarrao