Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2023.12 version of the array API #3901

Merged
merged 4 commits into from Feb 29, 2024

Conversation

honno
Copy link
Member

@honno honno commented Feb 28, 2024

The array API has just had its 2023.12 release (data-apis/array-api#755)... in Feb 2024 馃槄 This PR simply accepts api_version="2023.12" for extra.array_api.make_strategies_namespace().


I believe there aren't any changes that should necessitate what the strategies namespace is doing for 2023.12! I assume this will be an on-going trend, as I can't think of any existing discussions that would either shake-up the existing strategies or want us to add news ones.

I did have the idea to maybe just warn instead of erroring when api_version is greater than the last item of RELEASED_VERSIONS (and not draft), so we don't "annoy" libraries by asking them to use an older api_version kwarg for make_strategies_namespace() whilst they wait on us to update one variable upstream for a very trivial change 馃 I'm really not sure and might be something to just see how future array API iterations play out first.


It's also worth noting that numpy.array_api will most likely be removed at some point (numpy/numpy#25542) and superseded by the new array-api-strict third-party package. As that library is "official" and pretty stable (esp. for the purposes of what extra.array_api does), is that something we'd want for CI @Zac-HD? If so, I can try work out how to do CI things with some direction.

There's also array-api-compat which could be a good start in covering libraries other than NumPy (CuPy, PyTorch, Dask, possibly more in the future). I'll be having a think on it generally for the array API test suite (data-apis/array-api-tests#235) anywho.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few docs suggestions:

hypothesis-python/RELEASE.rst Show resolved Hide resolved
hypothesis-python/tests/array_api/README.md Show resolved Hide resolved
hypothesis-python/RELEASE.rst Outdated Show resolved Hide resolved
@Zac-HD
Copy link
Member

Zac-HD commented Feb 28, 2024

It's also worth noting that numpy.array_api will most likely be removed at some point (numpy/numpy#25542) and superseded by the new array-api-strict third-party package. As that library is "official" and pretty stable (esp. for the purposes of what extra.array_api does), is that something we'd want for CI @Zac-HD? If so, I can try work out how to do CI things with some direction.

Yeah, I'm happy to depend on that for our tests; open a PR whenever suits you 馃檪

There's also array-api-compat which could be a good start in covering libraries other than NumPy (CuPy, PyTorch, Dask, possibly more in the future). I'll be having a think on it generally for the array API test suite (data-apis/array-api-tests#235) anywho.

Ooooh, also nice. Definitely interested, but I trust your judgement and will leave details and implementation order to you.

* Clarify release notes
* Link to NEP directly
@honno honno requested a review from Zac-HD February 29, 2024 10:36
@Zac-HD
Copy link
Member

Zac-HD commented Feb 29, 2024

Thanks again @honno! I always feel that Hypothesis - and the wider ecosystem - is so lucky to have you maintaining this stuff 鈾ワ笍

@Zac-HD Zac-HD merged commit 164c4f0 into HypothesisWorks:master Feb 29, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants