-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-mapped strategies for populating numpy arrays #3858
Use non-mapped strategies for populating numpy arrays #3858
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
33f8f88
to
0345288
Compare
Hmm. I somewhat dislike adding a new
|
The first version (commit) of this PR did your no.1, I'm opposed to no.2 (using |
I haven't checked. Nonzero but trivial, I expect. |
This comment was marked as outdated.
This comment was marked as outdated.
@tybug could this be related to your recent work? Just a heads-up, it hasn't been bothering me since. |
6d93eb9
to
141fbe1
Compare
Advice needed: It looks like coverage is missing for some invalid inputs, but I don't understand why that starts happening now. And I don't quite understand the stacks either;
[edit: ...and |
thanks for the ping — definitely my fault in some way. I haven't seen it in #3818 recently, so it may have been fixed at some point in the interim on that branch (or I may just be unlucky). I'll take a look if it comes up again after that is merged. |
@@ -393,7 +399,6 @@ def do_draw(self, data): | |||
return result | |||
|
|||
|
|||
@check_function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this started failing, but also don't think it really needs to be a check function... so it's not.
Closes #3857