Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated HealthCheck.all() and add a codemod to convert it to list(HealthCheck) #3596

Closed
Zac-HD opened this issue Mar 16, 2023 · 0 comments · Fixed by #3610
Closed

Deprecated HealthCheck.all() and add a codemod to convert it to list(HealthCheck) #3596

Zac-HD opened this issue Mar 16, 2023 · 0 comments · Fixed by #3610
Labels
enhancement it's not broken, but we want it to be better

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Mar 16, 2023

As discussed in #3581 (comment)

@classmethod
def all(cls) -> List["HealthCheck"]:
# Skipping of deprecated attributes is handled in HealthCheckMeta.__iter__
# TODO: note_deprecation() and write a codemod for HC.all() -> list(HC)
return list(HealthCheck)

@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant