Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GraalPy #3587

Closed
wants to merge 1 commit into from

Conversation

timfel
Copy link
Contributor

@timfel timfel commented Feb 23, 2023

There are some checks for PyPy, but the branches for PyPy are really related to GC differences to CPython which apply to GraalPy just the same. With these changes I can pass most of the test suite on GraalPy (modulo some bugs on our end)

@Zac-HD
Copy link
Member

Zac-HD commented Feb 28, 2023

Hi Tim - thanks for this contribution! I've admired Graal from afar for some years now, and I'm really excited to get Hypothesis running on top of it 😁

It looks like the remaining CI failures are down to (1) a missing hypothesis-python/RELEASE.rst file, where we'll need to describe a patch release to get this through our CD system, and (2) a mysterious hang in our coverage jobs - I noticed this in #3589 too, so I don't think it's anything to do with these changes. Please bear with me if this takes a while to track down, I'm pretty short on time at the moment.

@timfel
Copy link
Contributor Author

timfel commented Feb 28, 2023

(1) a missing hypothesis-python/RELEASE.rst file, where we'll need to describe a patch release to get this through our CD system

I looked at that, but was unsure what the file should look like, but I just found an example in a different PR, so I'll add something like it.

(2) a mysterious hang in our coverage jobs - I noticed this in #3589 too, so I don't think it's anything to do with these changes.

Thank you for confirming that - I was stumped how I might have caused that :)

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks again, Tim!

I'll merge as soon as we debug and fix this hang 🙂

@Zac-HD
Copy link
Member

Zac-HD commented Mar 16, 2023

Cherry-picked into #3581 and released! (although the docs build is failing so it'll be a few hours before this appears in the changelog)

Thanks again Tim!

@Zac-HD Zac-HD closed this Mar 16, 2023
@timfel timfel deleted the timfel/support-graalpy branch March 16, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants