Add handling for from_regex and test for change #3550
Conversation
| strategy.function is st.from_type | ||
| or strategy.function.__name__ is st.from_regex.__name__ |
There was a problem hiding this comment.
Maybe strategy.function in (st.from_type, st.from_regex)?
We'll also want to handle more than just the first argument, in case of e.g. st.from_regex("pattern", flags=re.ASCII). If handling flags turns out to be a huge pain I'm happy to just open an issue about that for later, but it'd be good to investigate now in case we can support that with only minor changes.
There was a problem hiding this comment.
This sadly does not work, they get different memory addresses somehow, so it needs to be done via .__name__.
Probably iterating on ._LazyStrategy__kwargs and _LazyStrategy__args is the best bet.
There was a problem hiding this comment.
Also I just realized the from_regex does not support flags itself, they need to be included in the pattern after the last / or in the re.compile call
|
(Did a rebase) |
Use function call instead of function Switch to using sets
JensHeinrich
force-pushed
the
feature/handle-from_regex-import
branch
from
4c774cb
to
38ee9d3
Compare
|
New branch and cherry picked |
Well, if something annoys me and I can change it, I try to change it^^ |
|
❤️ open source! |
Fixes #3549