Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade regex-automata to latest version #3043

Closed
zhongzc opened this issue Dec 29, 2023 · 2 comments
Closed

Upgrade regex-automata to latest version #3043

zhongzc opened this issue Dec 29, 2023 · 2 comments

Comments

@zhongzc
Copy link
Contributor

zhongzc commented Dec 29, 2023

What type of enhancement is this?

Performance

What does the enhancement do?

In our inverted index implementation, we have utilized an FST (Finite State Transducer) as a key indexing structure, aiming to achieve excellent search capabilities.

The ability to perform regular expression matches is a particularly standout feature of the FST's search functionalities, and it's something we wish to incorporate into our system to provide more effective filtering for user queries. This capability primarily relies on the regex-automata library to compile regular expressions into DFAs (Deterministic Finite Automata), which are utilized for searching within the FST.

The current issue is that regex-automata only offers the functionality to compile to DFA in its early versions (0.1 and 0.2), and there are a number of limitations within these versions (as detailed in the repository's README). We are looking to upgrade regex-automata being used, while maintaining the search capability within the FST.

According to the description at rust-lang/regex#1087:

Note that you can always write the trait impls yourself for a wrapper type, so you can unblock yourself if necessary.

It appears that we might be able to achieve our goal by following this suggestion.

Implementation challenges

No response

@evenyag
Copy link
Contributor

evenyag commented Mar 27, 2024

@tisonkun @zhongzc Can we close this issue now?

@zhongzc
Copy link
Contributor Author

zhongzc commented Mar 27, 2024

@tisonkun @zhongzc Can we close this issue now?

yep

@zhongzc zhongzc closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants