No need to make runShadow depend on installShadowDist
#1353
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request removes the dependency of runShadow task on installShadowDist task, which simplifies the task execution and reduces unnecessary dependencies. The change seems straightforward and well-justified.
Merge Readiness
The code change is straightforward and addresses the stated goal of removing an unnecessary dependency. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Since there are no critical or high severity issues, the pull request appears ready for merging.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the changelog to clarify that runShadow no longer depends on installShadowDist.
- Updated the "Unreleased" section in the changelog.
Goooler
force-pushed
the
g/20250318/update-run-task
branch
from
db04d5e to
6ceabd5
Compare
- Split `installShadowOutputs` from `integrationWithApplicationPluginAndJavaToolchains`. - Tweak `canOverrideMainClassAttrInManifestBlock`.
Goooler
force-pushed
the
g/20250318/update-run-task
branch
from
6ceabd5 to
61d66ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installShadowOutputsfromintegrationWithApplicationPluginAndJavaToolchains.canOverrideMainClassAttrInManifestBlock.