Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark DefaultInheritManifest as internal #1303

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Mar 4, 2025


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Sorry, something went wrong.

@Goooler Goooler force-pushed the g/20250304/move-default-manifest-into-internal branch from 87b9f05 to a366754 Compare March 4, 2025 06:33
@Goooler Goooler requested a review from Copilot March 4, 2025 06:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the changelog to document the breaking change that marks DefaultInheritManifest as internal.

  • Updated CHANGELOG with a breaking change note for DefaultInheritManifest.
  • Reflects internal access modifier change.

Reviewed Changes

File Description
src/docs/changes/README.md Added a changelog entry documenting the internal marking of DefaultInheritManifest.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Verified

This commit was signed with the committer’s verified signature.
Goooler Zongle Wang
@Goooler Goooler force-pushed the g/20250304/move-default-manifest-into-internal branch from a366754 to 9916de3 Compare March 4, 2025 06:34
@Goooler Goooler enabled auto-merge (squash) March 4, 2025 06:36
@Goooler Goooler merged commit 63abc8c into main Mar 4, 2025
7 checks passed
@Goooler Goooler deleted the g/20250304/move-default-manifest-into-internal branch March 4, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant