Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport Spring Boot 3.2 compatibility updates to Spring Cloud GCP 4.x #2397

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

burkedavison
Copy link
Member

@burkedavison burkedavison commented Dec 1, 2023

These updates introduce source changes that will be required for Spring Boot 3.2.x compatibility, but do not update Spring Cloud GCP to use Spring Boot 3.2.x as Spring Cloud 2022 is not compatible and Spring Cloud 2023 has not yet been GA released.

Attempting to update to Spring Boot 3.2.x will cause a compatibility verification error if using any module requiring Spring Cloud 2022.

Related issue: #2379

burkedavison and others added 2 commits November 1, 2023 10:13
* deps: spring cloud 2023.0.0-M2 and spring boot 3.2.0-RC1

* fix: SpannerCompositeKeyProperty implements isReadable

* fix: PubSubHealthIndicatorAutoConfiguration uses indicator factory injection

* fix: SpannerHealthIndicatorAutoConfiguration uses indicator factory injection

* chore: add PubSubSubscriptionHealthIndicatorAutoConfigurationTests

* fix: PubSubSubscriptionHealthIndicatorAutoConfiguration explicitly does not support indicator creation

* fix: Remove @OverRide from SpannerCompositeKeyProperty.isReadable

* fix: PubSubSubscriptionHealthIndicatorAutoConfiguration generics changed

* chore: Test PubSubSubscriptionHealthIndicatorAutoConfiguration

* fix: imports

* fix: GqlDatastoreQuery isPaged logic
@burkedavison burkedavison requested a review from a team as a code owner December 1, 2023 21:56
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

pom.xml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@burkedavison burkedavison merged commit a640b75 into main Dec 4, 2023
53 checks passed
@burkedavison burkedavison deleted the spring-boot-3.2-backport branch December 4, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants