Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only commit change if it's not a snapshot version #2370

Merged
merged 5 commits into from Nov 22, 2023
Merged

feat: only commit change if it's not a snapshot version #2370

merged 5 commits into from Nov 22, 2023

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Nov 22, 2023 •
edited

@JoeWang1127 JoeWang1127 mentioned this pull request Nov 22, 2023
Merged
@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 22, 2023 16:09
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner November 22, 2023 16:09
@JoeWang1127
Copy link
Contributor Author

If the version is not set or contains SNAPSHOT, the workflow will not commit change to gh-pages branch, thus no reference docs update.

+ [[ -z '' ]]
+ echo -e 'SNAPSHOT version, do not commit.'

@JoeWang1127 JoeWang1127 enabled auto-merge (squash) November 22, 2023 17:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127 JoeWang1127 merged commit a50fb4b into main Nov 22, 2023
51 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/update-refdocs branch November 22, 2023 17:36
@release-please release-please bot mentioned this pull request Nov 22, 2023
Merged
@release-please release-please bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We shouldn't publish refdocs for SNAPSHOT versions
2 participants
@JoeWang1127 @lqiu96