-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collector: use buildinfo to make user agent #1022
collector: use buildinfo to make user agent #1022
Conversation
This PR adjusts the `NewGoogleCloud*Exporter` functions to take a `component.BuildInfo`, and to format that build info into the UserAgent instead of defaulting to `opentelemetry-collector-contrib`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 61.03% 64.31% +3.28%
==========================================
Files 56 58 +2
Lines 5903 6048 +145
==========================================
+ Hits 3603 3890 +287
+ Misses 2143 1999 -144
- Partials 157 159 +2 ☔ View full report in Codecov by Sentry. |
Opened a draft PR with the changes I made and tested with |
redo of #1018
This PR adjusts the
NewGoogleCloud*Exporter
functions to take acomponent.BuildInfo
, and to format that build info into the UserAgentinstead of defaulting to
opentelemetry-collector-contrib
.