Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector: use buildinfo to make user agent #1022

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Feb 21, 2025

redo of #1018

This PR adjusts the NewGoogleCloud*Exporter functions to take a
component.BuildInfo, and to format that build info into the UserAgent
instead of defaulting to opentelemetry-collector-contrib.

This PR adjusts the `NewGoogleCloud*Exporter` functions to take a
`component.BuildInfo`, and to format that build info into the UserAgent
instead of defaulting to `opentelemetry-collector-contrib`.
@braydonk braydonk requested a review from a team as a code owner February 21, 2025 20:25
@braydonk braydonk requested a review from dashpole February 21, 2025 20:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 82.45614% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (4caace7) to head (13f8e5a).
Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
exporter/collector/config.go 78.57% 3 Missing ⚠️
...llector/integrationtest/cmd/recordfixtures/main.go 0.00% 3 Missing ⚠️
exporter/collector/logs.go 0.00% 3 Missing ⚠️
...er/collector/integrationtest/protos/fixtures.pb.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   61.03%   64.31%   +3.28%     
==========================================
  Files          56       58       +2     
  Lines        5903     6048     +145     
==========================================
+ Hits         3603     3890     +287     
+ Misses       2143     1999     -144     
- Partials      157      159       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braydonk
Copy link
Contributor Author

Opened a draft PR with the changes I made and tested with go replace of this branch. When the new release is cut here, I will make this PR point to the release and open it for review.

open-telemetry/opentelemetry-collector-contrib#38116

@dashpole dashpole merged commit 90c5cf5 into GoogleCloudPlatform:main Feb 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants