Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove third-party mock library #124

Merged
merged 1 commit into from
Nov 13, 2023
Merged

deps: remove third-party mock library #124

merged 1 commit into from
Nov 13, 2023
+1 −3

Conversation

felixonmars
Copy link
Contributor

@felixonmars felixonmars commented Nov 13, 2023 •
edited
Loading

unittest.mock is present since Python 3.3+, we don't need to depend on the external library for compatibility.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Sorry, something went wrong.

@felixonmars felixonmars requested review from a team as code owners November 13, 2023 11:02
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 13, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 13, 2023
@clundin25
Copy link

Thank you for your contribution @felixonmars ! There are some linter failures. Can you resolve them? nox -s lint will run the linter.

@felixonmars
deps: remove third-party mock library

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b91df5e 
`unittest.mock` is present since Python 3.3+, we don't need to depend on
the external library for compatibility.
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2023
@clundin25
Copy link

Thank you for your contribution!

@clundin25 clundin25 merged commit ea0c7c6 into googleapis:main Nov 13, 2023
@release-please release-please bot mentioned this pull request Nov 13, 2023
Merged
@clundin25 clundin25 mentioned this pull request Nov 13, 2023
Closed
@felixonmars felixonmars deleted the mock branch November 13, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixonmars @clundin25 @parthea @yoshi-kokoro