fix: Configure unix socket library for Graalvm #1961
Merged
+311
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-1940-graalvm-config
branch
from
1009cc4 to
a8977cc
Compare
hessjcg
changed the base branch from
main
to
gh-1940-unix-socket-integration-test
enocom
reviewed
Apr 30, 2024
|
This is a complete fix. I've updated the comment. |
jackwotherspoon
approved these changes
Apr 30, 2024
|
cc @mpeddada1 as FYI |
mpeddada1
reviewed
May 1, 2024
Comment on lines
+5
to
+7
| -H:ReflectionConfigurationResources=META-INF/native-image/com.google.cloud.sql/cloud-sql-jdbc-socket-factory-parent/jni-unix-socket-config.json \ | ||
| -H:ResourceConfigurationResources=META-INF/native-image/com.google.cloud.sql/cloud-sql-jdbc-socket-factory-parent/resource-config.json \ | ||
| -H:DynamicProxyConfigurationResources=META-INF/native-image/com.google.cloud.sql/cloud-sql-jdbc-socket-factory-parent/proxy-config.json \ |
There was a problem hiding this comment.
optional q: I wonder if we need to specify these JSONs in native-image.properties? The compiler automatically picks up config files under the META-INF/native-image directory if the files follow a standard naming pattern (link)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the graalvm configuration issues related to the jnr.unixsocket library.
Fixes #1940