fix: Set Artifact ID using the static method. #1938
Merged
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
fix-artifact-id
branch
from
b13c8f4 to
251e282
Compare
hessjcg
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issue was reported in GoogleCloudPlatform/spring-cloud-gcp#2773:
the warning
Application name is not set. Call Builder#setApplicationName.is logged bycom.google.api.client.googleapis.services.AbstractGoogleClientwhenusing com.google.cloud:spring-cloud-gcp-starter-sql-postgresqlThe issue was caused by setting the Artifact ID using the instance method instead of the static one. Additionally, the library version was added to the Artifact ID by default, resulting in user agents like
spring-cloud-gcp-sql/5.1.2/1.17.2-SNAPSHOT mysql-socket-factory-connector-j-8/1.17.2-SNAPSHOT. This issue has been fixed.