Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage Monitor unexpectedly recognizes the root parent pom as a BOM #1958

Closed
suztomo opened this issue Feb 25, 2021 · 1 comment · Fixed by #1962
Closed

Linkage Monitor unexpectedly recognizes the root parent pom as a BOM #1958

suztomo opened this issue Feb 25, 2021 · 1 comment · Fixed by #1962
Assignees
Labels
bug Something isn't working

Comments

@suztomo
Copy link
Contributor

suztomo commented Feb 25, 2021

(This is a regression of #1920)

The problem in java-asset repository https://github.com/googleapis/java-asset/issues/570 was caused by Linkage Monitor unexpectedly recognizing the root pom.xml as a BOM and thus reading the dependencyManagement section to create a snapshot Libraries BOM.

We want to read the dependencyManagement section of BOMs to populate LinkageMonitor.localArtifacts, because gax-java repository has gax-bom to tell which artifacts are generated by the repository.

Note that google-cloud-bom is a BOM but LinkageMonitor.localArtifacts does not need to have its dependencyManagement section.

@suztomo suztomo changed the title Linkage Monitor recognizes the root parent pom as a BOM Linkage Monitor unexpectedly recognizes the root parent pom as a BOM Feb 25, 2021
suztomo added a commit that referenced this issue Feb 25, 2021
@suztomo suztomo self-assigned this Feb 26, 2021
@suztomo suztomo added the bug Something isn't working label Feb 26, 2021
@suztomo
Copy link
Contributor Author

suztomo commented Feb 26, 2021

gax-java can generate the artifact list file with a simple task:

task createLinkageMonitorArtifactList {
  doLast {
    new File(projectDir, "linkage-monitor-artifacts.txt").text = """
com.google.api:gax:$version
com.google.api:gax-grpc:$version
com.google.api:gax-httpjson:$version
"""
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment