Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage Monitor fails to detect linkage errors in gax-java #1919

Closed
suztomo opened this issue Jan 21, 2021 · 1 comment · Fixed by #1920
Closed

Linkage Monitor fails to detect linkage errors in gax-java #1919

suztomo opened this issue Jan 21, 2021 · 1 comment · Fixed by #1920

Comments

@suztomo
Copy link
Contributor

suztomo commented Jan 21, 2021

Linkage Monitor fails to detect linkage errors in gax-java.

Linkage Monitor has capability to replace a BOM in the libraries BOM. However, we no longer specify gax-bom in it. Therefore current it does not detect anything in gax-java's repository.

This bug is only applicable for gax-java repository, which relies on gax-java BOM to tell locally installed artifacts. Other Maven projects in Yoshi repositories, which produces pom.xml files in project directories, are not affected.

@suztomo
Copy link
Contributor Author

suztomo commented Feb 26, 2021

  1. Read pom.xml (done) and build.gradle. Does this exist?
  2. Check target directories. gax-java does not generate pom files.
  3. Each repository to have a list of artifacts.
    not in ci.yaml : https://github.com/googleapis/java-spanner/blob/master/.github/workflows/ci.yaml for synthtool
    independent files in each repository. 80+ repositories... Respect the current working procedure so that we only need files for special repositories.

I'll do with a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant