Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support innerText locators #1988

Merged
merged 2 commits into from
Mar 20, 2024
Merged

feat: support innerText locators #1988

merged 2 commits into from
Mar 20, 2024

Conversation

sadym-chromium
Copy link
Collaborator

@sadym-chromium sadym-chromium commented Mar 11, 2024 •
edited

Start implement innerText locator in browsingContext.locateNodes using WebAPI.

Out of scope:

  • maxNodeCount
  • maxDepth

Base automatically changed from sadym/xpath-locator to main March 11, 2024 16:37
@sadym-chromium sadym-chromium changed the title feat: support innerText locators [WIP]: support innerText locators Mar 12, 2024
@sadym-chromium sadym-chromium added the DO NOT MERGE Don't merge the marked PR label Mar 12, 2024
@sadym-chromium
Copy link
Collaborator Author

sadym-chromium commented Mar 13, 2024 •
edited

Actually, the innerText selector cannot be implemented via xPath text(), as the latest does not respect the text of the nested nodes.

Implemented directly how it is specified.

@sadym-chromium sadym-chromium removed the DO NOT MERGE Don't merge the marked PR label Mar 20, 2024
@sadym-chromium sadym-chromium force-pushed the sadym/inner-text branch 2 times, most recently from 4788e97 to 331cd98 Compare March 20, 2024 14:30
@sadym-chromium sadym-chromium changed the title [WIP]: support innerText locators feat: support innerText locators Mar 20, 2024
@sadym-chromium sadym-chromium marked this pull request as ready for review March 20, 2024 14:30
@sadym-chromium sadym-chromium force-pushed the sadym/inner-text branch 2 times, most recently from b959f42 to 18f42d2 Compare March 20, 2024 15:50
sadym-chromium and others added 2 commits March 20, 2024 17:56
@sadym-chromium
feat: InnerTextLocator
488c379
@sadym-chromium
Update WPT expectations
79db835 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sadym-chromium sadym-chromium enabled auto-merge (squash) March 20, 2024 16:56
@sadym-chromium sadym-chromium merged commit 8c41582 into main Mar 20, 2024
35 checks passed
@sadym-chromium sadym-chromium deleted the sadym/inner-text branch March 20, 2024 17:07
@release-please release-please bot mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@Lightning00Blade Lightning00Blade Awaiting requested review from Lightning00Blade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sadym-chromium @OrKoN