Pick the first non-null target for INP attribution #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
reviewed
Jan 23, 2024
Co-authored-by: Barry Pollard <barrypollard@google.com>
tunetheweb
requested changes
Jan 23, 2024
Co-authored-by: Barry Pollard <barrypollard@google.com>
|
@mmocny can you review? |
mmocny
approved these changes
Jan 23, 2024
|
This PR is similar to the strategy I've been advertising for measuring interaction targets. -- There is also a different strategy that works around the other problem with event targets... that they can be removed and GC-ed by the time Event Timing is reported. That gist is very rough, but gives you the idea: manage a map of event type + timestamp to whatever metadata you want, saved during event dispatch, then look it up from Event Timing. |
philipwalton
requested changes
Jan 23, 2024
Co-authored-by: Philip Walton <philipwalton@users.noreply.github.com>
tunetheweb
approved these changes
Jan 23, 2024
|
I added a test to cover the logic Rick added. It fails when run against |
philipwalton
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pointer entries have a known bug causing them to have null event targets. In cases where there are mouse or click entries in the same interaction that do have non-null event targets, always prefer those.
This PR works around the bug by changing the
eventTargetin INP attribution to use the first entry in the list having a non-null target, rather than always using the longest entry in the list, which may sometimes be a pointer entry.