Fix static subresource paths for server/viewer #879
Merged
+53
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875
Basically a continuation from last year's #753 and more specifically #786
The short version is... esbuild consuming HTML and css is rough. Parcel treated us well.
in 786 we fixed static serving (the viewer) but made sure the express-based serving (the server) still worked.
it did until it didnt. maybe some dependency bumps? shrug.
But...... this works.
I spent a bunch of time making a more generalized solution. I ended up for something sliiiiightly more specific, but I'm still happy with it.
oh.. and just like in #786 ...
some development notes
of course the root problem is plenty of because paths. and express (sometimes) but not all the time.
i used these to iterate.