Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add portStrictMode option #319

Merged
merged 3 commits into from Sep 29, 2023
Merged

add portStrictMode option #319

merged 3 commits into from Sep 29, 2023

Conversation

connorjclark
Copy link
Collaborator

I need this to ensure that I am connecting to a mobile device, and to fail if that expected port is not available (as opposed to silently fallback to launching Chrome on the current device).

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming wise i don't love this one.. but.. as mentioned on chat... nothing is immediately great.

portStrictMode is the best ive got... lets do that ? sure.

README.md Outdated Show resolved Hide resolved
@connorjclark connorjclark changed the title add failIfNoChromeAtPort option add portStrictMode option Sep 29, 2023
Co-authored-by: Paul Irish <paulirish@users.noreply.github.com>
@connorjclark connorjclark merged commit f7b24a0 into main Sep 29, 2023
10 checks passed
@connorjclark connorjclark deleted the fail-no-port branch September 29, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants