Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow construct CustomFormat outside the crate #1638

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

tisonkun
Copy link
Contributor

@Byron One question is that shall we use Cow<'static, str> instead to allow define a non-static format?

It breaks the Copy trait somehow so I don't make this change. And a static format is sufficient for my use cases.

tisonkun and others added 2 commits October 21, 2024 09:52

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
refactor

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
- improve docs
@Byron Byron force-pushed the allow-contructCustomFormat branch from c3d04fa to 4910912 Compare October 21, 2024 07:54
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Note that I adjusted the commit-message so this becomes a feature to be added to the changelog.

One question is that shall we use Cow<'static, str> instead to allow define a non-static format?

It's probably something for another time once there is demand. That would require dynamic formats to be used, which probably is quite rare.

@Byron Byron enabled auto-merge October 21, 2024 07:58
@tisonkun
Copy link
Contributor Author

@Byron Thank you!

I checked the logs and didn't find a consistent pattern on messages: Some follow the conventional commits flavor and others follow a capital message.

From your comment it seems conventional commits should be used consistently, if so I'll apply it for the potential following contributions :D

@tisonkun
Copy link
Contributor Author

It's probably something for another time once there is demand. That would require dynamic formats to be used, which probably is quite rare.

Yeah. So let's avoid to be too generic too early :D

@Byron Byron merged commit bcdce6e into GitoxideLabs:main Oct 21, 2024
16 checks passed
@tisonkun tisonkun deleted the allow-contructCustomFormat branch October 21, 2024 08:14
@Byron
Copy link
Member

Byron commented Oct 21, 2024

From your comment it seems conventional commits should be used consistently, if so I'll apply it for the potential following contributions :D

Actually that's not the case. They are only used if something should go into the changelog, and to signal breaking changes as well. That's why it's not always used, just sometimes.

@tisonkun
Copy link
Contributor Author

just sometimes.

OK.

Besides, I'm using this crate with gix = { ... }. Is there an estimated date when I can expect to get a new version with this change? Or, how the gitoxide's crates typically get released?

@Byron
Copy link
Member

Byron commented Oct 21, 2024

Usually on the 22nd of each month there is a new release.

@tisonkun
Copy link
Contributor Author

Looks like I'm lucky 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants