freelist control #1603
Merged
freelist control #1603
+136
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by three new `Repository` methods: * `empty_reusable_buffer()` - hook into the free-list yourself. * `set_freelist()` - enable or initialize the free-list. * `without_freelist()` - a builder to disable the freelist from the start.
fbstj
reviewed
Sep 23, 2024
| /// Freelist configuration | ||
| /// | ||
| /// The free-list is an internal and 'transparent' mechanism for obtaining and re-using memory buffers when | ||
| /// reading objects. That way, trashing is avoided as buffers are re-used and re-written. |
There was a problem hiding this comment.
Suggested change
| /// reading objects. That way, trashing is avoided as buffers are re-used and re-written. | |
| /// reading objects. That way, thrashing is avoided as buffers are re-used and re-written. |
is this a typo?
There was a problem hiding this comment.
Oh wow, it wasn't a typo, but I realised now that it's not trashing at all :D.
fbstj
reviewed
Sep 23, 2024
Comment on lines
+53
to
+54
| /// They are welcome to take out the data themselves, for instance when the object is detached, to avoid | ||
| /// it to be reclaimed. |
There was a problem hiding this comment.
Suggested change
| /// They are welcome to take out the data themselves, for instance when the object is detached, to avoid | |
| /// it to be reclaimed. | |
| /// They are welcome to take out the data themselves, for instance when the object is detached, to avoid | |
| /// it being reclaimed. |
is this correct? I think otherwise the sentence is wonky
There was a problem hiding this comment.
Thanks for the review! Would you be able to raise a new PR with the changes? Otherwise I can probably U-Boot the changes into the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1599 .
Tasks