[ISSUE]: gitrealeasemanager/create does not include targetcommitish and inputFilePath parameters

[TaffarelJr]

Prerequisites

• I have written a descriptive issue title
• I have searched issues to ensure it has not already been reported

GitVersion package

GitHub Actions

What are you seeing?

When using the gitreleasemanager/create action, there are parameters defined for targetcommitish and inputFilePath; however, upon execution, those parameters are not included in the command line sent to dotnet-gitreleasemanager.

Sample GitHub Action:

- uses: gittools/actions/gitreleasemanager/create@v3
  with:
    owner: ${{ github.repository_owner }}
    token: ${{ secrets.GITHUB_TOKEN }}
    repository: my-repo
    targetDirectory: ${{ github.workspace }}
    targetcommitish: ${{ github.sha }}              # <-- property is valid
    name: v${{ steps.gitversion.outputs.semVer }}
    inputFilePath: ReleaseNotes.md                  # <-- property is valid

Command-line generated from the above Action (wrapped for readability):

/opt/hostedtoolcache/GitReleaseManager.Tool/0.18.0/dotnet-gitreleasemanager create
  --owner my-org
  --token ***
  --repository my-repo
  --targetDirectory /home/runner/work/my-repo/my-repo
  --name v1.2.3

( --targetcommitish and --inputFilePath command-line parameters left out)

What is expected?

--targetcommitish and --inputFilePath command-line parameters should be included, as specified in the Action:

/opt/hostedtoolcache/GitReleaseManager.Tool/0.18.0/dotnet-gitreleasemanager create
  --owner my-org
  --token ***
  --repository my-repo
  --targetDirectory /home/runner/work/my-repo/my-repo
  --targetcommitish edf8f64259dca665f01c1da5fff9650b7e342b69
  --name v1.2.3
  --inputFilePath ReelaseNotes.md

Steps to Reproduce

Include the targetcommitish and inputFilePath parameters in a GitHub Action,
and observe the corresponding --targetcommitish and --inputFilePath command-line parameters are not generated.

Output log or link to your CI build (if appropriate).

[TaffarelJr]

The workaround to this issue, of course, is to just call the command-line manually in the workflow instead of using the Action. This is currently working for me:

- run: >
    $RUNNER_TOOL_CACHE/GitReleaseManager.Tool/0.18.0/dotnet-gitreleasemanager create
    --owner ${{ github.repository_owner }}
    --token ${{ secrets.GITHUB_TOKEN }}
    --repository my-repo
    --targetDirectory ${{ github.workspace }}
    --targetcommitish ${{ github.sha }}
    --name v${{ steps.gitversion.outputs.semVer }}
    --inputFilePath ReleaseNotes.md

[arturcic]

@TaffarelJr you are right. Are you in a position to create a PR?
some refs:

Settings:

actions/src/tools/gitreleasemanager/models.ts

Line 14 in f41cc13

inputFileName: string

actions/src/tools/gitreleasemanager/models.ts

Line 16 in f41cc13

commit: string

actions/src/tools/gitreleasemanager/settings.ts

Line 30 in f41cc13

const inputFileName = this.buildAgent.getInput<CreateSettings>('inputFileName')

actions/src/tools/gitreleasemanager/settings.ts

Line 32 in f41cc13

const commit = this.buildAgent.getInput<CreateSettings>('commit')

Inputs:

actions/gitreleasemanager/create/action.yml

Line 31 in f41cc13

inputFilePath:

actions/gitreleasemanager/create/action.yml

Line 39 in f41cc13

targetcommitish:

actions/dist/azure/gitreleasemanager/create/task.json

Line 66 in f41cc13

"name": "inputFilePath",

actions/dist/azure/gitreleasemanager/create/task.json

Line 82 in f41cc13

"name": "targetcommitish",

Tests:

actions/src/__tests__/tools/gitreleasemanager/tool.spec.ts

Line 203 in f41cc13

commit: 'commit',

actions/src/__tests__/tools/gitreleasemanager/tool.spec.ts

Line 205 in f41cc13

inputFileName: 'inputFileName',

actions/src/__tests__/tools/gitreleasemanager/settings.spec.ts

Line 23 in f41cc13

inputFileName: 'inputFileName',

[arturcic]

please use inputFilePath and targetcommitish everywhere where necessary

[gittools-bot]

🎉 This issue has been resolved in version v3.1.2 🎉
The release is available on:

• GitHub Release

Your GitReleaseManager bot 📦🚀