Skip to content

[Improvement]: Create TaggedSemanticVersionService class #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
HHobeck opened this issue Apr 14, 2024 · 1 comment · Fixed by #4003
Closed
2 tasks done

[Improvement]: Create TaggedSemanticVersionService class #4002

HHobeck opened this issue Apr 14, 2024 · 1 comment · Fixed by #4003

Comments

@HHobeck
Copy link
Contributor

HHobeck commented Apr 14, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitVersion.Tool

GitVersion version

6.0.0-beta.7

Operating system

N/A

What are you seeing?

Create TaggedSemanticVersionService class

What is expected?

TaggedSemanticVersionService class should be existing with following methods:

ILookup<ICommit, SemanticVersionWithTag> GetTaggedSemanticVersions(
    IBranch branch,
    IGitVersionConfiguration configuration,
    string? label,
    DateTimeOffset? notOlderThan,
    TaggedSemanticVersions taggedSemanticVersion);

ILookup<ICommit, SemanticVersionWithTag> GetTaggedSemanticVersionsOfBranch(
    IBranch branch,
    string? tagPrefix,
    SemanticVersionFormat format,
    IIgnoreConfiguration ignore,
    string? label = null,
    DateTimeOffset? notOlderThan = null);

ILookup<ICommit, SemanticVersionWithTag> GetTaggedSemanticVersionsOfMergeTarget(
    IBranch branch,
    string? tagPrefix,
    SemanticVersionFormat format,
    IIgnoreConfiguration ignore,
    string? label = null,
    DateTimeOffset? notOlderThan = null);

ILookup<ICommit, SemanticVersionWithTag> GetTaggedSemanticVersionsOfMainBranches(
    IGitVersionConfiguration configuration,
    DateTimeOffset? notOlderThan = null,
    string? label = null,
    params IBranch[] excludeBranches);

ILookup<ICommit, SemanticVersionWithTag> GetTaggedSemanticVersionsOfReleaseBranches(
    IGitVersionConfiguration configuration,
    DateTimeOffset? notOlderThan = null,
    string? label = null,
    params IBranch[] excludeBranches);

Steps to Reproduce

Move functionality from TaggedSemanticVersionRepository to TaggedSemanticVersionService class

RepositoryFixture Test

No response

Output log or link to your CI build (if appropriate).

No response

@HHobeck HHobeck added this to the 6.x milestone Apr 14, 2024
@arturcic arturcic modified the milestones: 6.x, 6.0.0-rc.1 May 23, 2024
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-rc.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants