Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Git push does not transfer tags #3740

Closed
SRNissen opened this issue Oct 27, 2023 · 5 comments · Fixed by #3741
Closed

[Docs] Git push does not transfer tags #3740

SRNissen opened this issue Oct 27, 2023 · 5 comments · Fixed by #3741

Comments

@SRNissen
Copy link
Contributor

SRNissen commented Oct 27, 2023

NB: This is not a problem with gitversion-the-software, but it sure did take me long to find out why gitversion wasn't updating.

Starting this off: Gitversion gave different numbers locally and in my github job.

Reading the FAQ:


image


Well, then I clicked the link and on that page I saw:


image


And I knew that I had God damn well tagged my commits.

So I went to the issue tracker and, yeah, there were issues about tags not being tracked - closed issues, by people who had resolved their problems, so ... probably not an issue with gitversion-the-software?

And then I read up on git tags (which I have never used before getting into gitversion) and found out that git push does not transfer tags, which explains the whole thing.

But it would have been nice to read that in the FAQ on gitversion. It happened to me - it could happen to others.

@asbjornu
Copy link
Member

Good idea. A pull request documenting this would be merged for sure! 👍🏼

@SRNissen
Copy link
Contributor Author

Sure, I've got a PR ready.

Do I fork the repo or do you grant access to creating branches in this repo or how is the preferred contribution style here? (...which I might as well add to CONTRIBUTING.md while I'm at it)

@arturcic
Copy link
Member

Please create a fork and create the PR

@SRNissen
Copy link
Contributor Author

Well the PR doesn't build

I can confirm, independently of the testing workflow, that the link causing the build failure does not work.

It is a link in a different part of the documentation, located at:

https://gitversion.net/docs/learn/branching-strategies/githubflow/

that has nothing to do with this change.

Still, it might be better to do something about the issue. Are there any policies on removing links?

@arturcic arturcic added this to the 6.x milestone Nov 6, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.4 Dec 12, 2023
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-beta.4 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants