Fix ignore list #138
Merged
Fix ignore list #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files inside a .git/ folder were being removed even with FREEZER_DESTINATION_IGNORE set.
|
Thanks for the pull request! There’s a big problem in this feature, sorry for the inconvenience. I’ll fix the code so that it’s closer to what it was before 1.0.0, and closer to .gitignore (as advertised by the documentation). |
|
@Siecje I’ve added more tests, we now cover more cases (including your example). If it’s OK for you, we can merge this PR and release a new version! |
|
This is great! It also passes my tests in my project. Thanks for working on this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files inside a
.git/folder were being removedeven with
FREEZER_DESTINATION_IGNOREset.