Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Duplicated definitions for "IconName" in fontawesom-common-types #20220

Open
2 tasks done
olmobrutall opened this issue May 17, 2024 · 3 comments
Open
2 tasks done
Assignees
Labels
Milestone

Comments

@olmobrutall
Copy link

Bug description

Taking a look at index.d.ts in "fontawesome-common-files" i realized is a huge file with 39K lines!

The reason is that it looks generated from your icon library, but all the icon names that appear in different styles (regular/solid/thin...) are duplicated.

Ordering the file alphabetically with Notepad++ shows this clearly:

 'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-exclamation' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-fair' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-slash' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-strong' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi-weak' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi1' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi2' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wifi3' | 
  'wikipedia-w' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-circle-exclamation' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-turbine' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'wind-warning' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 
  'window' | 

Removing duplicates reduces the file to 4.828 lines aprox.

Reproducible test case

No response

Screenshots

No response

Font Awesome version

v6.5.2

Serving

Other (as specified in the bug description)

Implementation

SVG+JS

Browser and Operating System

It's a Typescript Bug, any development IDE.

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@olmobrutall olmobrutall added bug needs-triage This bug needs to be confirmed labels May 17, 2024
@robmadole
Copy link
Member

@olmobrutall nice find! Let me see if I can get this addressed for the next release. Thank you.

@robmadole
Copy link
Member

We've got this fixed up and ready to go out in the next release.

@tagliala tagliala added this to the 6.5.3 milestone May 17, 2024
@tagliala tagliala removed the needs-triage This bug needs to be confirmed label May 17, 2024
@olmobrutall
Copy link
Author

Wow! That was fast. Thanks a lot 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants