Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction in Brazilian Portuguese Translation of "ExactLength_Simple" Message #2130

Closed
renanl23 opened this issue Aug 1, 2023 · 3 comments · Fixed by #2131
Closed

Correction in Brazilian Portuguese Translation of "ExactLength_Simple" Message #2130

renanl23 opened this issue Aug 1, 2023 · 3 comments · Fixed by #2131
Milestone

Comments

@renanl23
Copy link
Contributor

renanl23 commented Aug 1, 2023

FluentValidation version

11.6.0

ASP.NET version

.NET 6

Summary

Hello everyone,

We have identified a minor grammatical inaccuracy in the Brazilian Portuguese translation of the "ExactLength_Simple" message in project.

Steps to Reproduce

Currently, the message is being translated as:
"ExactLength_Simple" => "'{PropertyName}' deve ter no máximo {MaxLength} caracteres.",

We suggest correcting the message to the following format:
"ExactLength_Simple" => "'{PropertyName}' deve ter {MaxLength} caracteres de comprimento.",

The word "máximo" is not appropriate in this translation, as it implies that the value of {MaxLength} is the maximum allowed, when in fact, it indicates the exact size that the property must have.

This change will ensure a better understanding of the message for Brazilian users and avoid possible confusion regarding property size requirements.

We would greatly appreciate it if someone could review and implement this translation change.

Thank you all for your attention and constant effort to make FluentValidation more user-friendly and accessible to everyone!

@JeremySkinner
Copy link
Member

JeremySkinner commented Aug 2, 2023

Please could you open a PR to correct this? Thanks! (I expect this was one which went through google translate as the *_Simple versions of the errors were added at a later date)

@renanl23
Copy link
Contributor Author

renanl23 commented Aug 3, 2023

PR opened #2131

@JeremySkinner JeremySkinner linked a pull request Aug 3, 2023 that will close this issue
@JeremySkinner
Copy link
Member

Merged, thanks!

@JeremySkinner JeremySkinner modified the milestones: 11.6.1, 11.7 Aug 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants