Error during importing Public keys from a file

[DenBond7]

I'm working on FlowCrypt/flowcrypt-android#1692. After trying to import the provided file with public keys I saw the following

This file contains a lot of public keys. Maybe we have to allow importing good keys and show a warning for bad keys.
@sosnovsky I will send you the file.

[sosnovsky]

This file contains a lot of public keys. Maybe we have to allow importing good keys and show a warning for bad keys.
@sosnovsky I will send you the file.

Usually it works the way you described - valid keys are imported, and for invalid ones we show warning (https://github.com/FlowCrypt/flowcrypt-browser/blob/master/extension/chrome/settings/modules/contacts.ts#L111).

Maybe currently all keys are invalid in provided file, as it's more than 1 year old and keys can expire since then.

@DenBond7 were you able to import any key from this file on Android?

[DenBond7]

Usually it works the way you described - valid keys are imported, and for invalid ones we show warning

Yes, for example for this file pub_keys_5_good_1_unsupported.txt

@DenBond7 were you able to import any key from this file on Android?

Yup. This one FlowCrypt/flowcrypt-android#2326 allows doing that.

[sosnovsky]

Yes, for example for this file pub_keys_5_good_1_unsupported.txt

Yeah, current UI isn't very informative, I'll file separate issue for it, thanks for reporting!

[ioanmo226]

Please send me key file you are testing

[DenBond7]

Please send me key file you are testing

I've sent ))

[sosnovsky]

@ioanmo226 during my check I found that issue probably happens at getSortedUserids

[ioanmo226]

From my research, this error happens at below line (OpenPGP verifyAllUsers function returns error for current key)and I can see that Mart already reported issue at OpenPGP.
@sosnovsky I think we should wait for next OpenPGP release and just update OpenPGP version.
Let me know what you think.

flowcrypt-browser/extension/js/common/core/crypto/pgp/openpgp-key.ts

Line 543 in 951cf0f

...Value.arr.unique((await key.verifyAllUsers()).filter(x => x.valid && x.userID !== primaryUserId).map(x => x.userID)),

openpgpjs/openpgpjs#1637

[sosnovsky]

@sosnovsky I think we should wait for next OpenPGP release and just update OpenPGP version.

Agree 👍 Then nothing needs to be done here for now, just re-check that issue is fixed with the next openpgp release.
Thanks for checking!