Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VONK-4846: Include the title (or name) of the value set in the error message #2469

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented May 23, 2023

Description

Include the title (or name) of the value set in the error message when validating a code against a value set. This PR is part of a broader issue aimed at aligning the error output with that of the Java validator.

Related issues

Resolves issue VONK-4846

Testing

  • unit test: Hl7.Fhir.Specification.Tests.LocalTerminologyServiceTests.CodeNotFoundMessageTest

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

Sorry, something went wrong.

@marcovisserFurore marcovisserFurore marked this pull request as ready for review May 23, 2023 10:53
…t-in-the-error-message-of-the-LocalTerminologyService
@mmsmits mmsmits self-requested a review May 23, 2023 12:13
…t-in-the-error-message-of-the-LocalTerminologyService
@marcovisserFurore marcovisserFurore merged commit edf2935 into develop May 23, 2023
@marcovisserFurore marcovisserFurore deleted the feature/VONK-4864-Add-the-name-of-Valueset-in-the-error-message-of-the-LocalTerminologyService branch May 23, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants