Add optional support for GetAllAsync() via HttpRemoteStore #848
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackburn29
force-pushed
the
get_all_via_http_store
branch
from
823d576 to
174cf22
Compare
|
@dotnet-policy-service agree |
|
thanks @Blackburn29 |
AndrewTriesToCode
pushed a commit
that referenced
this pull request
Oct 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2024
# [8.0.0](v7.0.2...v8.0.0) (2024-10-12) * feat!: version policy update ([#888](#888)) ([487a3a6](487a3a6)) ### Bug Fixes * BasePathStrategy no longer breaks the strategy chain ([#884](#884)) ([3263eff](3263eff)) * prevent duplicate key annotation in AdjustKey() ([#883](#883)) ([f75ba2c](f75ba2c)) * removed unused parameter from WithPerTenantRemoteAuthenticationConvention ([#886](#886)) ([dd17ab5](dd17ab5)) ### Features * add GetAllAsync() support for HttpRemoteStore ([#848](#848)) ([4208149](4208149)) * added the Echo Store. ([#807](#807)) ([a3e5eee](a3e5eee)) * strategies return null on invalid context type ([#885](#885)) ([9834575](9834575)) ### BREAKING CHANGES * This commit brings the release into alignment with the new version policy. See #887 for details. * Included strategies for ASP.NET Core would throw an exception if the passed context was not an `HttpContext` type. Now they will return null indicating no identifier was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue while converting from an EF store to HTTP in a project. My comment on issue #808 mainly provides the need for this and I managed to implement it manually within my app, however I'd like to mainline this for future projects. I can definitely understand why people would not want this, which is why I based the implementation off the existing route template and will throw
NotImplementedExceptionin the case of the external http service having an undefined route for this implementation.Feedback is greatly appreciated!