Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Preserve annotations when adjusting index (#829) #832

Merged
merged 2 commits into from
Aug 3, 2024
Merged

fix: Preserve annotations when adjusting index (#829) #832

merged 2 commits into from
Aug 3, 2024
+42 −0

Conversation

fbjerggaard
Copy link
Contributor

Fixes #829

@fbjerggaard
Copy link
Contributor Author

@dotnet-policy-service agree

AndrewTriesToCode
AndrewTriesToCode requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@AndrewTriesToCode AndrewTriesToCode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add similar annotation copying down in AdjustKey prior to the removal of the pre-existing key?

@fbjerggaard
Copy link
Contributor Author

I knew I forgot something - should be all done now.

@AndrewTriesToCode AndrewTriesToCode merged commit e765340 into Finbuckle:main Aug 3, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Aug 3, 2024
@semantic-release-bot
chore: 7.0.2 [skip ci]
5d02a2d 
## [7.0.2](v7.0.1...v7.0.2) (2024-08-03)

### Bug Fixes

* Preserve annotations when adjusting index ([#832](#832)) ([e765340](e765340))
* strategy wrapper no longer throws on a null context, instead passing it to the actual strategy ([#863](#863)) ([2b165c7](2b165c7))
@fbjerggaard fbjerggaard deleted the fix-829 branch August 11, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewTriesToCode AndrewTriesToCode

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations not preserved with adjustindexes [NPGSQL]
2 participants
@fbjerggaard @AndrewTriesToCode