feat: improved perf for HostStrategy (#936)

lahma · web-flow · commit a70f7e0f47ea · 2025-02-08T13:08:49.000-07:00
diff --git a/src/Finbuckle.MultiTenant.AspNetCore/Strategies/HostStrategy.cs b/src/Finbuckle.MultiTenant.AspNetCore/Strategies/HostStrategy.cs
@@ -10,9 +10,9 @@
 
 namespace Finbuckle.MultiTenant.AspNetCore.Strategies;
 
-public class HostStrategy : IMultiTenantStrategy
+public sealed class HostStrategy : IMultiTenantStrategy
 {
-    private readonly string regex;
+    private readonly Regex regex;
 
     public HostStrategy(string template)
     {
@@ -62,7 +62,7 @@ public HostStrategy(string template)
             template = template.Replace(Constants.TenantToken, @"(?<identifier>[^\.]+)");
         }
 
-        this.regex = $"^{template}$";
+        this.regex = new Regex($"^{template}$", RegexOptions.ExplicitCapture | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
     }
 
     public Task<string?> GetIdentifierAsync(object context)
@@ -77,9 +77,7 @@ public HostStrategy(string template)
 
         string? identifier = null;
 
-        var match = Regex.Match(host.Host, regex,
-            RegexOptions.ExplicitCapture,
-            TimeSpan.FromMilliseconds(100));
+        var match = regex.Match(host.Host);
 
         if (match.Success)
         {

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,9 @@`
`10`	`10`
`11`	`11`	`namespace Finbuckle.MultiTenant.AspNetCore.Strategies;`
`12`	`12`
`13`		`-public class HostStrategy : IMultiTenantStrategy`
	`13`	`+public sealed class HostStrategy : IMultiTenantStrategy`
`14`	`14`	`{`
`15`		`- private readonly string regex;`
	`15`	`+ private readonly Regex regex;`
`16`	`16`
`17`	`17`	`public HostStrategy(string template)`
`18`	`18`	`{`
`@@ -62,7 +62,7 @@ public HostStrategy(string template)`
`62`	`62`	`template = template.Replace(Constants.TenantToken, @"(?<identifier>[^\.]+)");`
`63`	`63`	`}`
`64`	`64`
`65`		`- this.regex = $"^{template}$";`
	`65`	`+ this.regex = new Regex($"^{template}$", RegexOptions.ExplicitCapture \| RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`public Task<string?> GetIdentifierAsync(object context)`
`@@ -77,9 +77,7 @@ public HostStrategy(string template)`
`77`	`77`
`78`	`78`	`string? identifier = null;`
`79`	`79`
`80`		`- var match = Regex.Match(host.Host, regex,`
`81`		`- RegexOptions.ExplicitCapture,`
`82`		`- TimeSpan.FromMilliseconds(100));`
	`80`	`+ var match = regex.Match(host.Host);`
`83`	`81`
`84`	`82`	`if (match.Success)`
`85`	`83`	`{`