Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should app context types accept additional properties? #809

Open
NickColley opened this issue May 7, 2020 · 0 comments
Open

Should app context types accept additional properties? #809

NickColley opened this issue May 7, 2020 · 0 comments

Comments

@NickColley
Copy link
Contributor

In #782 we updated the schema to prevent people from adding additional data to app context. However when I look at the type
definitions they seem to allow for additional properties still with [key: string]: any.

Should we remove this from the type definitions?

I'm very much new to TypeScript types so I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant