Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fast-async in the ft-js plugin to help keep the size of the generator output for async/await reasonable #23

Open
ifeanyiisitor opened this issue Nov 12, 2018 · 4 comments
Open

Implement fast-async in the ft-js plugin to help keep the size of the generator output for async/await reasonable #23

ifeanyiisitor opened this issue Nov 12, 2018 · 4 comments
Assignees
@apaleslimghost
Labels
Blocked Enhancement New feature or request

Comments

@ifeanyiisitor
Copy link
Contributor

ifeanyiisitor commented Nov 12, 2018 •
edited by i-like-robots

https://github.com/MatAtBread/fast-async
@ifeanyiisitor ifeanyiisitor added the Enhancement New feature or request label Nov 12, 2018
@i-like-robots i-like-robots changed the title Implement https://github.com/MatAtBread/fast-async in the ft-js plugin to help keep the size of the generator output for async/await sane. Implement fast-async in the ft-js plugin to help keep the size of the generator output for async/await sane. Nov 13, 2018
@i-like-robots
Copy link
Contributor

I've been testing https://www.npmjs.com/package/babel-plugin-transform-async-to-promises#output-with-inlinehelpers-enabled and it seems quite good. It has smaller output fast-async and keeps the code readable IMO. There are some lengthy discussions between the author of fast-async and Regenerator and the benefits of fast-async do appear to be oversold.

@i-like-robots
Copy link
Contributor

I'm going to close this issue as stale. It may be one to pick up as part of a specific performance project in future.

@i-like-robots
Copy link
Contributor

i-like-robots commented Jul 15, 2019 •
edited

I'm going to re-open this as since we initially discussed it the plugin mentioned above has been added to Next.js so I assume we should now be able to use it with confidence.

https://www.npmjs.com/package/babel-plugin-transform-async-to-promises

@i-like-robots i-like-robots reopened this Jul 15, 2019
@i-like-robots i-like-robots added this to the Release 0.2.0 milestone Jul 15, 2019
@apaleslimghost apaleslimghost changed the title Implement fast-async in the ft-js plugin to help keep the size of the generator output for async/await sane. Implement fast-async in the ft-js plugin to help keep the size of the generator output for async/await reasonable Sep 9, 2019
@apaleslimghost apaleslimghost self-assigned this Sep 9, 2019
@apaleslimghost apaleslimghost mentioned this issue Sep 9, 2019
Closed
@i-like-robots i-like-robots removed this from the Release v0.3.0 milestone Oct 14, 2019
@i-like-robots
Copy link
Contributor

I've removed the milestone as the PR is currently blocked due to an issue in the plugin that's been implemented.

@i-like-robots i-like-robots added this to the Release v0.7.0 milestone Jan 21, 2020
@i-like-robots i-like-robots removed this from the Release v0.7.0 milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apaleslimghost apaleslimghost

Labels
Blocked Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use babel-plugin-transform-async-to-promises Financial-Times/dotcom-page-kit
3 participants
@i-like-robots @apaleslimghost @ifeanyiisitor