Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to distinguish between null and empty #471

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

PujolDavid
Copy link
Contributor

Following the issue: #469

I made a pull request with that proposal:

  • Add a new feature EMPTY_UNQUOTED_STRING_AS_NULL
  • Implement it like EMPTY_STRING_AS_NULL
  • Add tests

Note that I made this PR on the branch 2.18, but I'm using the version 2.15 in my projects (Spring boot 3.1)
If accepted we can move this feature also to previous versions

@cowtowncoder
Copy link
Member

Since this is API addition, SemVer would not allow us to backport it. In practical terms, it is unlikely new 2.15 versions will be released. But I could perhaps be convinced that merging into 2.17 (for 2.17.1) would be ok as "dark launch" (that is, officially feature is only available on 2.18 but in practice is included earlier if you know where to look).

@PujolDavid
Copy link
Contributor Author

That would be great to have it on 2.17.1
Tell me if you want me to rebase on the 2.17 branch.


After that, what will be the next step?
Will I need to do something else or it's now on your side?

@cowtowncoder
Copy link
Member

I can cherry-pick change back to 2.17 if everything works, so 2.18 is fine.

But one other thing I need is CLA, from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print it, fill & sign, scan/photo, email to cla at fasterxml dot com.
This only needs to be done once before the first contribution, and then is good for any and all contributions to Jackson components.

I hope to review this PR soon, hopefully today.

@PujolDavid
Copy link
Contributor Author

Document sent, Thanks

@cowtowncoder
Copy link
Member

All good with CLA; I have been busy but will try to get this reviewed and merged tomorrow.

@cowtowncoder cowtowncoder merged commit b8aa54e into FasterXML:2.18 Apr 10, 2024
4 checks passed
@cowtowncoder
Copy link
Member

Ok, so: this went officially in 2.18 for 2.18.0, but I did cherry-pick it for 2.17 branch: so technically it will go in as undocumented feature of 2.17.1 ("dark launch" so to speak).

@PujolDavid
Copy link
Contributor Author

Great thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants