Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastdoubleparser 1.0.0 #1163

Merged
merged 2 commits into from Dec 11, 2023
Merged

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Dec 10, 2023

@pjfanning
Copy link
Member Author

@cowtowncoder this should fox the NPE in #1161

I would like to backport this to 2.16.1 if that's ok. Users who enable fast parsing of big decimals could easily hit the NPE.

@@ -182,6 +182,7 @@ com.fasterxml.jackson.core.*;version=${project.version}
<artifact>ch.randelshofer:fastdoubleparser</artifact>
<excludes>
<exclude>META-INF/versions/**/module-info.*</exclude>
<exclude>META-INF/versions/22/**/*.*</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cowtowncoder
Copy link
Member

@cowtowncoder this should fox the NPE in #1161

I would like to backport this to 2.16.1 if that's ok. Users who enable fast parsing of big decimals could easily hit the NPE.

I was about to suggest the same, +1 for backport to 2.16.1.

@cowtowncoder cowtowncoder merged commit d28275d into FasterXML:2.17 Dec 11, 2023
5 checks passed
@cowtowncoder
Copy link
Member

Merged to master (part of it manual due to ignoral of pom.xml merge failures).

@pjfanning pjfanning deleted the upgrade-fastparser branch December 11, 2023 00:17
pjfanning added a commit to pjfanning/jackson-core that referenced this pull request Dec 11, 2023
cowtowncoder pushed a commit that referenced this pull request Dec 11, 2023
pjfanning added a commit to pjfanning/jackson-core that referenced this pull request Dec 11, 2023
cowtowncoder pushed a commit that referenced this pull request Dec 11, 2023
cowtowncoder pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants