Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in "FastDoubleParser", method "JavaBigDecimalParser.parseBigDecimal()" #1161

Closed
cowtowncoder opened this issue Dec 10, 2023 · 3 comments
Closed

NPE in "FastDoubleParser", method "JavaBigDecimalParser.parseBigDecimal()" #1161

cowtowncoder opened this issue Dec 10, 2023 · 3 comments
Labels
2.15 Issue planned (at earliest) for 2.15 2.16 Issue planned (at earliest) for 2.16
Milestone
2.16.1

Comments

@cowtowncoder
Copy link
Member

(note: regression due to #1157)

Looks like there is an NPE in FDP, method JavaBigDecimalParser#parseBigDecimal for Strings of length 1000 (and seemingly even less).
I will do a PR with reproduction.
cowtowncoder added a commit that referenced this issue Dec 10, 2023
@cowtowncoder
Reproduction for #1161
4e07a63
@wrandelshofer wrandelshofer mentioned this issue Dec 10, 2023
Closed
@wrandelshofer
Copy link

I made a fix and have released it as version 1.0.0 of fastdoubleparser.
https://github.com/wrandelshofer/FastDoubleParser/releases/tag/v1.0.0

Please let me know, if the fix works for you.

@pjfanning
Copy link
Member

Thanks @wrandelshofer for the prompt fix - I'll try out the 1.0.0 release when it hits https://repo1.maven.org/maven2/ch/randelshofer/fastdoubleparser/ (maven central).

@pjfanning pjfanning mentioned this issue Dec 10, 2023
Merged
cowtowncoder added a commit that referenced this issue Dec 11, 2023
@cowtowncoder
Reproduction for #1161 (#1162)
b5f1ae3
@cowtowncoder cowtowncoder added 2.15 Issue planned (at earliest) for 2.15 2.16 Issue planned (at earliest) for 2.16 labels Dec 11, 2023
@cowtowncoder cowtowncoder added this to the 2.16.1 milestone Dec 11, 2023
cowtowncoder added a commit that referenced this issue Dec 11, 2023
@cowtowncoder
Update release notes wrt #1161
7f1c619
@cowtowncoder
Copy link
Member Author

Fixed in 2.16 for 2.16.1 (and 2.17); may be backported to 2.15 depending.

cowtowncoder added a commit that referenced this issue Dec 12, 2023
@cowtowncoder
Update release notes wrt #1161 backport
8f37646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.15 Issue planned (at earliest) for 2.15 2.16 Issue planned (at earliest) for 2.16
Projects
None yet
Milestone
2.16.1
Development

No branches or pull requests
3 participants
@cowtowncoder @wrandelshofer @pjfanning