Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the right filterFinishArray()/filterFinishObject() from FilteringParserDelegate #1111

Merged

Conversation

dmikurube
Copy link
Contributor

Hi,

While I was tackling https://groups.google.com/g/jackson-user/c/bLZTjjjXZ28 , I found that filterFinishObject is not called properly under some condition. filterFinishArray is called against "}" instead of filterFinishObject.

The first commit is a new test to confirm this behavior (the added test should fail before the second commit), and the second commit fixes the issue.


I created this pull request against 2.15 because https://github.com/FasterXML/jackson/blob/master/CONTRIBUTING.md says :

Most bug-fix Pull Requests should be made against the current stable branch,

(but "the current stable branch" may be now 2.15, not 2.14?)

Please tell me if another branch should be the base.


I have not signed/sent the CLA yet. I'll do it in a couple of days.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Sep 23, 2023
@cowtowncoder
Copy link
Member

@dmikurube First of all, thank you for this contribution! Always great to get a bug report AND matching fix.

Second, yes, 2.15 is fine since this looks like very safe fix (low likelihood of regression). I can then merge it forward to 2.16.

Third: one formality before I can merge this in: I need a CLA (from https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf) -- it's one-pager and only needs to be sent once before the first contribution, works for all future contributions.
The easiest way is usually to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I receive it I'll proceed with merging.

Thank you once again for the fix!

@dmikurube
Copy link
Contributor Author

Thanks, @cowtowncoder!

Yeah, sorry to be late. I sent my CLA just now.

@cowtowncoder cowtowncoder added 2.15 Issue planned (at earliest) for 2.15 and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Sep 23, 2023
@cowtowncoder
Copy link
Member

CLA received, will merge.

@cowtowncoder cowtowncoder merged commit e2d2fc2 into FasterXML:2.15 Sep 23, 2023
5 checks passed
@cowtowncoder cowtowncoder changed the title Call the right filterFinishArray/Object from FilteringParserDelegate Call the right filterFinishArray()/filterFinishObject() from FilteringParserDelegate Sep 23, 2023
cowtowncoder added a commit that referenced this pull request Sep 23, 2023
@dmikurube
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.15 Issue planned (at earliest) for 2.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants