Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlockView API v2 not applying WorldViewMixin #4500

Merged

Conversation

PepperCode1
Copy link
Member

Fix #4499.

This fix should be backported to as many versions as possible.

@PepperCode1 PepperCode1 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Mar 14, 2025
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Mar 14, 2025
@modmuss50
Copy link
Member

This proves why we need tests, and should ideally be adding one. Im happy to merge this as is as its clearly broken.

@modmuss50 modmuss50 merged commit 9c49cc8 into FabricMC:1.21.4 Mar 16, 2025
4 checks passed
modmuss50 pushed a commit that referenced this pull request Mar 16, 2025
(cherry picked from commit 9c49cc8)
modmuss50 pushed a commit to modmuss50/fabric that referenced this pull request Mar 16, 2025
(cherry picked from commit 9c49cc8)
(cherry picked from commit aa6d566)
modmuss50 pushed a commit to modmuss50/fabric that referenced this pull request Mar 16, 2025
(cherry picked from commit 9c49cc8)
(cherry picked from commit aa6d566)
modmuss50 added a commit that referenced this pull request Mar 19, 2025
(cherry picked from commit 9c49cc8)
(cherry picked from commit aa6d566)

Co-authored-by: PepperCode1 <44146161+PepperCode1@users.noreply.github.com>
modmuss50 added a commit that referenced this pull request Mar 19, 2025
(cherry picked from commit 9c49cc8)
(cherry picked from commit aa6d566)

Co-authored-by: PepperCode1 <44146161+PepperCode1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge me please Pull requests that are ready to merge priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants