Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle exception on subscription initialization #1940

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Handle exception on subscription initialization #1940

merged 1 commit into from
Mar 25, 2024
+93 −9

Conversation

pdambrauskas
Copy link
Contributor

📝 Description

In case of Subscription initiation failure, for example exception thrown after some custom authentication/authorisation mechanism throws exception, error was not passed through as response body, because of exception:

java.lang.NullPointerException: graphQL.execute(input)
    …<Flow<ExecutionResult>>() must not be null
   at com.expediagroup.graphql.server.execution.GraphQLRequestHandler.executeSubscription(GraphQLRequestHandler.kt:167)

🔗 Related Issues

@samuelAndalon samuelAndalon self-requested a review March 25, 2024 16:46
@samuelAndalon samuelAndalon merged commit d8eb4ce into ExpediaGroup:master Mar 25, 2024
10 checks passed
@pdambrauskas pdambrauskas deleted the handle_subscription_init_error branch March 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelAndalon samuelAndalon

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdambrauskas @samuelAndalon